https://gitlab.synchro.net/main/sbbs/-/commit/3ff043da84462d6cf5db9a64
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Log warning-level message when we can't auto-add a sub

... because there's no linked-node configured as the uplink for the parent message group.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/d652854faa37cb4cdf507938
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Address some MSVC static analysis warnings

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/fabef9ea90ed2758081eec2a
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Only log one warning per invocation about inability to auto-add sub

Just the first sub that couldn't be auto-added.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/8010070c0bc86aaf8104a144
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Take the configured origin line chars into account when determining charset

and if the message is UTF-8, encode the origin line as UTF-8 too.
If the message is straight ASCII (e.g. the sub-board is configured as ASCII only), convert the configured origin line to ASCII, before appending.

At this time, only ASCII and CP437 encodings of originlines are supported
in Synchronet (imported and exported origin lines can contain UTF-8).

This should address the issue raise by Sergey Dorofeev (2:5020/12000) in the FidoNet UTF-8 echo whereby messages exported from Synchronet systems (presumably using SBBSecho) could contain a mixture of CP437 and UTF-8 encodings (!) when the sysop had CP437 chars in their configured origin line.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ca0d64e4e73f352dbfcd4f1b
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Eliminate some unnecessary typecasts and parens

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f78d5395969b6a38a4db8adc
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Add typecast to elminate GCC warning

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/6d037195018beb8a946bdebb
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
When netmail is forwarded to an external (netmai/email) address, notify user

Include the appropriate text.dat string (like the mail server does) in
short message sent to user.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/3bcc0d624061d1833c15ecbf
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
If the area file is configured to be blank, don't try to open/read

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/faf0f4d29ca57bdcc0d130c5
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Fix handling of .msg files from IBBS doors.

IBBS doors configured for Binkley style outbound will put the
binkley directives in the subject, expecting them to pass through
to the FLO file.

SBBSEcho v2 and v3 since a3b2f9e2d have stripped the "delete file"
indication ('^') and generated an error, refusing to send messages
with #, ~, -, !, and @.

This changes the behaviour to translate '-' to '^', '!' to '~', and
strip '@', and keep the prefix that was in the .msg file.

This fixes the issue where outbound files from IBBS games configured
for Binkley style outbound would never get deleted.

Note that in this implementation, the prefix overrides the configured truncation value and any "FLAGS KFL" kludge lines.

---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/377ac0563666ae3852f33cef
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Fix last commit to not include the prefix when validating the filename

Derp.

---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/aa7a1b6505417cfcdcc8530b
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Previous "fix" actually broke more than it fixed.

I wouldn't call me a real developer.

---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/3b527199322f25832617f964
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Fix potential buffer overflow in fmsgattr_str()

Pass it 0xffff and it overflows its local (static) string buffer.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/41e2191514f2a45fe862b6b4
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Replace import_netmail() magic constansts with (expanded) IMPORT_* enum values

The only really important values (other than for debug-logging reasons) are
0 (success) and IMPORT_CLOSED (was -2).

One functional change included here: when fmsgtosmsg returned non-zero values, import_netmail() would log the value and still return 0 (success). This will result in more debug-level log msgs when fmsgtosmsg() returns an error value, but that's all.

The logged import_netmail() error numbers *are* changed by this commit.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/d5b59539e7e688f57ce3c43e
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Implement Deuce's suggested fix for importing netmail messages (.msg files)

... for robots.

I thought he said he was importing packets, but in any case, we don't want to be deleting a .msg file destined for a configured robot.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/e7b93ae3f3f8dfb24d450f1c
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Clean up import_netmail()

- No longer use special return value (IMPORT_CLOSED) to indicate the .msg
file was closed. Now we just set the FILE* to NULL if it was closed and
return IMPORT_SUCCESS.
- No longer deletes the .msg file here; expect the caller (main()) to do that. - Update the message header here (e.g. adding "RECEIVED" attribute flag),
when appropriate. Sometimes this was added here, sometimes in the main(),
and in some cases it should not have been added (e.g. for ignored and
filtered netmail messages) but it was anyway.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/5b21df6e401a7b3071c44f8b
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Fix typo in previous commit

Weird that it compiled without warning. I didn't try linking it, so that's why it wasn't caught.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f8a33572e1e6fe5ac9887856
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Remove direct printf() calls from import_netmail()

... direct all output through lprintf() instead.

This insures that the helpful output may always be logged to the sbbsecho.log file and the sysop need not view the stdout to find out why a netmail message was ignored or discarded or otherwise problematic.

It appeared there may have been redundant output to stdout before anyway and trying to keep both the stdout and the log output both helpful and beautified was getting tedius.

Most sysops don't look at the console/stdout of sbbsecho when it runs and we normally expect a sysop to be able to use the sbbsecho.log file to debug any issues (possibly after increasing their log level to DEBUG).

Include the netmail message attributes value (both in hex and verbose form)
in the information logged about an incoming netmail message.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/e69955e0e7e951634ad90f48
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Replace integer constants 0 and 1 with values of appropriate type (e.g. bool)

Code clean-up, no functional change.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/241bd37f9feb34506c3b295d
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Better logging around area list file open failures

This also fixes the empty "Title" key/valiue lines in the echostats.ini file.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: Re: src/sbbs3/sbbsecho.c
By: Gamgee to MRO on Tue Feb 04 2025 06:41 pm

MRO wrote to k9zw <=-

Alas my system merged this in another echo... puzzling how at the
moment... appreciate the reply!

put your data files in their own sub directory for each msg network
you have.

That isn't necessary and certainly is not the default way.

But it does keep the directories a little tidier.

... Remember how simple life was when there were only two sexes?

---
þ Synchronet þ the Outwest BBS - outwest.synchro.net - Home of BBSBASE 6.0

https://gitlab.synchro.net/main/sbbs/-/commit/9c4557e96766bb7e6b73edf4
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Fix a couple more new-GCC warnings

using gcc (GCC) 15.2.1 20260209 "assignment discards const qualifier"

reported by Accession

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/3422dabc7807f1fff56ebb9e
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Fix compile errors on GCC 15.2

error: passing argument 2 of ‘getfmsg’ from incompatible pointer type [-Wincompatible-pointer-types]

---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/326057fd5c56c0c77a5e0d34
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
sbbsecho: free pkt->filename on fopen failure in find_stray_packets (CID 530517)

When the new outpkt_t cannot be opened for append, free(pkt) was called
without first releasing the strdup'd pkt->filename, leaking the path
for every stray packet whose append-open fails.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/9ef727bc25d13118b3ba5323
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
sbbsecho: cast away unchecked chmod/remove returns in alter_areas (CIDs 462777, 515046)

Both calls in alter_areas() are best-effort: the chmod is a permission
preserve before rename, and the remove is documented to be expected to
fail when the file doesn't exist. Make the ignore-return intent explicit
with (void) casts so Coverity stops flagging them as CHECKED_RETURN.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/4fc976e4a95c2afe121425e6
Modified Files:
src/sbbs3/sbbsecho.c
Log Message:
Don't import netmail addressed to an inactive user's number

import_netmail() resolves a numeric "To:" field with atoi() straight from
the packet, which short-circuits lookup_user() -- the only thing in this
path that skips deleted users. Nothing downstream catches it either: fmsgtosmsg() calls getuserdat(), which returns USER_SUCCESS for a deleted record, and no check guards the RECIPIENTEXT field written from it. A
remote system could therefore deposit netmail into a deleted user's
record, where it stays invisible until the record is recycled.

Reject an inactive account where the number is resolved, so the message
falls through to the existing lookup_user() / default_recipient /
"Unknown user" handling rather than changing what fmsgtosmsg() reports to
its callers. This matches the SMTP RCPT TO path, which already rejects a recipient that isn't an active account.

Fixes #1187

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net